Colorwaves slow after update

Issues
1

Hello! In my 24x128 matrix, the Colorwaves effect went from ~30 fps (a month ago) to ~9 fps.

My setup is two vertical 8x128 panels, separated by 8 pixels, so matrix size 24x128.

Was there a recent change that could have caused this?

2

That may be my bug. I’m investigating. Sometimes the .bin still doesn’t get updated and I got confused by that. I have to always remove .buildcache as per Source code build issue.

3

I found out something very strange. I have an effect, 2Dchillplasma, which is mostly a copy of 2Ddistortionwaves. My configuration boots automatically into 2Dchillplasma, so it is executed first.

If I comment out the following lines at the end of chillplasma (copied from distortionwaves):

  if(!SEGMENT.check1 && SEGMENT.palette)
    SEGMENT.blur(200, true);

Then I update the firmware and reboot, and then I select distortionwaves. The effect drops to 15 fps.

If I leave them uncommented, update, reboot, and select distortionwaves, the effect is at 36 fps.

This is very reproducible.

4

need to provide a github link to your code, can’t work with guesses and and two lines of code.

5

I’m looking into reproducing it with just the wled code on github.

6

I wasn’t able to reproduce it at head of main in github.

7

A commit on the last few days must have fixed it:

I rebased my changes on top of HEAD as of today, and now I can comment out the SEGMENT.blur() lines and colorwaves is not slow anymore.

8

still cant comment without knowing what you did.

9

Thank you for reading. Sorry, I can’t publish any code due to work contract (even though wled is not work-related).

I couldn’t reproduce it with pure wled without my changes, so all is good!

10

So you are taking free open source code, making modifications and then making it closed source, while asking for help from the Dev’s that are so kind as to provide the open source :face_with_raised_eyebrow: mmmk..

11

I’m not making open-source project closed-source except for my own use. It’s an art project. I will not (and am not allowed to) distribute it in any way, open or closed. I wish I could make it open source.

I thought I found a problem and I wanted to help investigate it. I asked if anyone knew of a recent change that could have caused it.

I’m very thankful to the developers, and I wish people that try to help receive less of these attacks. If I’m not welcome to post here because I can’t make my code open source, I’ll stop.